Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cardano-deposit-wallet lib ui and exe code #5006

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Remove cardano-deposit-wallet lib ui and exe code #5006

merged 4 commits into from
Feb 26, 2025

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Feb 26, 2025 •
edited
Loading

Changes

  • Remove cardano-deposit-wallet exe haskell and nix code
  • Remove cardano-deposit-wallet-ui
  • Remove cardano-deposit-wallet library

Issues

#4985

@paolino paolino force-pushed the paolino/4985/remove-deposit-wallet-exe branch from 3c8da6a to 36a2c49 Compare February 26, 2025 14:17
@paolino paolino changed the base branch from paolino/4985/split-ui-lib-between-deposit-and-shelley to master February 26, 2025 14:22
@paolino paolino self-assigned this Feb 26, 2025
@paolino paolino added Refactoring No functional changes Deposit labels Feb 26, 2025
@paolino paolino enabled auto-merge February 26, 2025 14:29
HeinrichApfelmus
HeinrichApfelmus approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@paolino paolino added this pull request to the merge queue Feb 26, 2025
@paolino paolino removed this pull request from the merge queue due to a manual request Feb 26, 2025
@paolino paolino force-pushed the paolino/4985/remove-deposit-wallet-exe branch from 36a2c49 to 9d5f6dd Compare February 26, 2025 15:35
@paolino paolino changed the base branch from master to paolino/4985/split-ui-lib-between-deposit-and-shelley February 26, 2025 15:53
@paolino paolino force-pushed the paolino/4985/remove-deposit-wallet-exe branch 2 times, most recently from 3139060 to 53ee680 Compare February 26, 2025 16:01
Base automatically changed from paolino/4985/split-ui-lib-between-deposit-and-shelley to master February 26, 2025 16:10
@paolino paolino force-pushed the paolino/4985/remove-deposit-wallet-exe branch from 0fe175d to e2cab0e Compare February 26, 2025 16:20
@paolino paolino enabled auto-merge February 26, 2025 16:20
@paolino paolino changed the title Remove cardano-deposit-wallet exe code Remove cardano-deposit-wallet lib ui and exe code Feb 26, 2025
@paolino paolino added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@paolino paolino merged commit 9631dcd into master Feb 26, 2025
25 checks passed
@paolino paolino deleted the paolino/4985/remove-deposit-wallet-exe branch February 26, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Deposit Refactoring No functional changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus